Skip to content

fix: ensure IAM Role name length does not exceed 64 characters #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npalm merged 7 commits into from
Sep 9, 2025
Merged

fix: ensure IAM Role name length does not exceed 64 characters #4696

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bdcd44
fix: ensure IAM Role name length does not exceed 64 characters
aarongorka Aug 6, 2025
8a7fbcc
Merge branch 'main' into fix-iam-role-name-length
npalm Aug 14, 2025
d348c24
Merge branch 'main' into fix-iam-role-name-length
npalm Sep 3, 2025
184c6c8
Update modules/runner-binaries-syncer/runner-binaries-syncer.tf
npalm Sep 3, 2025
33cc133
ensure roles are unique
npalm Sep 3, 2025
1471663
rename and align lambda roles
npalm Sep 3, 2025
0231349
Merge branch 'main' into fix-iam-role-name-length
npalm Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ami-housekeeper/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ resource "aws_cloudwatch_log_group" "ami_housekeeper" {
}

resource "aws_iam_role" "ami_housekeeper" {
name = "${var.prefix}-ami-housekeeper-role"
name = substr("${var.prefix}-ami-housekeeper-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = local.role_path
permissions_boundary = var.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/lambda/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ resource "aws_cloudwatch_log_group" "main" {
}

resource "aws_iam_role" "main" {
name = "${var.lambda.prefix}-${var.lambda.name}"
name = substr("${var.lambda.prefix}-${var.lambda.name}", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = local.role_path
permissions_boundary = var.lambda.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/policies-runner.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
data "aws_caller_identity" "current" {}

resource "aws_iam_role" "runner" {
name = "${var.prefix}-runner-role"
name = substr("${var.prefix}-runner-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = templatefile("${path.module}/policies/instance-role-trust-policy.json", {})
path = local.role_path
permissions_boundary = var.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/pool/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ resource "aws_cloudwatch_log_group" "pool" {
}

resource "aws_iam_role" "pool" {
name = "${var.config.prefix}-action-pool-lambda-role"
name = substr("${var.config.prefix}-action-pool-lambda-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = var.config.role_path
permissions_boundary = var.config.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/scale-down.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ resource "aws_lambda_permission" "scale_down" {
}

resource "aws_iam_role" "scale_down" {
name = "${var.prefix}-action-scale-down-lambda-role"
name = substr("${var.prefix}-action-scale-down-lambda-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = local.role_path
permissions_boundary = var.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/scale-up.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ resource "aws_lambda_permission" "scale_runners_lambda" {
}

resource "aws_iam_role" "scale_up" {
name = "${var.prefix}-action-scale-up-lambda-role"
name = substr("${var.prefix}-action-scale-up-lambda-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = local.role_path
permissions_boundary = var.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/ssm-housekeeper.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ resource "aws_lambda_permission" "ssm_housekeeper" {
}

resource "aws_iam_role" "ssm_housekeeper" {
name = "${var.prefix}-ssm-hk-lambda"
name = substr("${var.prefix}-ssm-hk-lambda", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
description = "Lambda role for SSM Housekeeper (${var.prefix})"
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = local.role_path
Expand Down
2 changes: 1 addition & 1 deletion modules/setup-iam-permissions/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
data "aws_caller_identity" "current" {}

resource "aws_iam_role" "deploy" {
name = "${var.prefix}-terraform"
name = substr("${var.prefix}-terraform", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated

permissions_boundary = aws_iam_policy.deploy_boundary.arn
assume_role_policy = templatefile("${path.module}/policies/assume-role-for-account.json", {
Expand Down
2 changes: 1 addition & 1 deletion modules/webhook/direct/webhook.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
}

resource "aws_iam_role" "webhook_lambda" {
name = "${var.config.prefix}-direct-webhook-lambda-role"
name = substr("${var.config.prefix}-direct-webhook-lambda-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = var.config.role_path
permissions_boundary = var.config.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/webhook/eventbridge/dispatcher.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ resource "aws_lambda_permission" "allow_cloudwatch_to_call_lambda" {
}

resource "aws_iam_role" "dispatcher_lambda" {
name = "${var.config.prefix}-dispatcher-lambda-role"
name = substr("${var.config.prefix}-dispatcher-lambda-role", 0, 63)
Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = var.config.role_path
permissions_boundary = var.config.role_permissions_boundary
Expand Down
2 changes: 1 addition & 1 deletion modules/webhook/eventbridge/webhook.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
}

resource "aws_iam_role" "webhook_lambda" {
name = "${var.config.prefix}-eventbridge-webhook-lambda-role"
name = substr("${var.config.prefix}-eventbridge-webhook-lambda-role", 0, 63)
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Truncating role names to 63 characters may result in non-unique names when multiple long prefixes share the same truncated portion. Consider adding a hash suffix or validation to ensure uniqueness when truncation occurs.

Suggested change
name = substr("${var.config.prefix}-eventbridge-webhook-lambda-role", 0, 63)
name = "${substr("${var.config.prefix}-eventbridge-webhook-lambda-role", 0, 54)}-${substr(md5("${var.config.prefix}-eventbridge-webhook-lambda-role"), 0, 8)}"

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@npalm npalm Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not applied to other aws_iam_role addressed in this PR?

Comment thread
npalm marked this conversation as resolved.
Outdated
assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json
path = var.config.role_path
permissions_boundary = var.config.role_permissions_boundary
Expand Down
Loading