fix: Log org / repository context when unable to match labels#4761
Merged
npalm merged 2 commits intogithub-aws-runners:mainfrom Sep 18, 2025
globalchubby:fix/issue-4760
Merged
fix: Log org / repository context when unable to match labels#4761npalm merged 2 commits intogithub-aws-runners:mainfrom globalchubby:fix/issue-4760
npalm merged 2 commits intogithub-aws-runners:mainfrom
globalchubby:fix/issue-4760
Conversation
globalchubby
changed the title
globalchubby
changed the title
globalchubby
commented
Sep 12, 2025
Refactors the workflow job dispatch logic to handle non-'queued' actions first, returning early with a 201 status. Updates the sorting and dispatching logic for matcherConfig, and improves warning messages for unaccepted runner labels by including the repository name. This ensures jobs are only dispatched when appropriate and provides clearer logging.
globalchubby
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves logging context when GitHub webhook events contain runner labels that don't match any configured runners. The fix adds organization and repository information to error messages to help with debugging.
- Adds repository context (
body.repository.full_name) to error messages when labels are not accepted - Refactors conditional logic using early return pattern to reduce nesting
- Consolidates error message creation to avoid duplication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@npalm Friendly ping? It's been a week and I think this PR is fairly simple / straightforward. |
npalm
approved these changes
Sep 18, 2025
Member
npalm
left a comment
npalm
left a comment
There was a problem hiding this comment.
@yangmillstheory thx, looks good and checked.
npalm
pushed a commit
that referenced
this pull request
Sep 18, 2025
🤖 I have created a release *beep* *boop* --- ## [6.7.8](v6.7.7...v6.7.8) (2025-09-18) ### Bug Fixes * **dispatcher:** Log org / repository context when unable to match labels ([#4761](#4761)) ([e214177](e214177)) @yangmillstheory * **lambda:** bump axios from 1.12.1 to 1.12.2 in /lambdas ([#4772](#4772)) ([4d0ad0a](4d0ad0a)) * **lambda:** bump axios from 1.8.4 to 1.12.0 in /lambdas ([#4763](#4763)) ([bbf1bd8](bbf1bd8)) * **lambda:** bump the aws group in /lambdas with 7 updates ([#4769](#4769)) ([7f30dca](7f30dca)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([#4770](#4770)) ([dbb6888](dbb6888)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
…bels (github-aws-runners#4761) Fixes github-aws-runners#4760. Also some code hygiene: use early continue to minimize nesting and a large `if` block.
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [6.7.8](github-aws-runners/terraform-aws-github-runner@v6.7.7...v6.7.8) (2025-09-18) ### Bug Fixes * **dispatcher:** Log org / repository context when unable to match labels ([github-aws-runners#4761](github-aws-runners#4761)) ([e214177](github-aws-runners@e214177)) @yangmillstheory * **lambda:** bump axios from 1.12.1 to 1.12.2 in /lambdas ([github-aws-runners#4772](github-aws-runners#4772)) ([4d0ad0a](github-aws-runners@4d0ad0a)) * **lambda:** bump axios from 1.8.4 to 1.12.0 in /lambdas ([github-aws-runners#4763](github-aws-runners#4763)) ([bbf1bd8](github-aws-runners@bbf1bd8)) * **lambda:** bump the aws group in /lambdas with 7 updates ([github-aws-runners#4769](github-aws-runners#4769)) ([7f30dca](github-aws-runners@7f30dca)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([github-aws-runners#4770](github-aws-runners#4770)) ([dbb6888](github-aws-runners@dbb6888)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4760.
Also some code hygiene: use early continue to minimize nesting and a large
ifblock.