feat: add cpu_options for EC2 launch template#4789
Merged
npalm merged 2 commits intogithub-aws-runners:mainfrom Oct 3, 2025
Merged
feat: add cpu_options for EC2 launch template#4789npalm merged 2 commits intogithub-aws-runners:mainfrom
npalm merged 2 commits intogithub-aws-runners:mainfrom
Conversation
kirschem-fernride
force-pushed
the
kirschem/add-cpu-options
branch
from
55c421e to
c784c56
Compare
npalm
changed the title
npalm
approved these changes
Oct 3, 2025
Member
There was a problem hiding this comment.
@kirschem-fernride thx looks good! Quick pro tip, when contributing to OS would be great if you can enable signed commits.
npalm
added a commit
that referenced
this pull request
Oct 3, 2025
🤖 I have created a release *beep* *boop* --- ## [6.8.0](v6.7.9...v6.8.0) (2025-10-03) ### Features * add cpu_options for EC2 launch template ([#4789](#4789)) ([20eeead](20eeead)) @kirschem-fernride ### Bug Fixes * **lambda:** bump the aws group across 1 directory with 7 updates ([#4805](#4805)) ([3025930](3025930)) * **lambda:** bump the octokit group in /lambdas with 3 updates ([#4794](#4794)) ([73cf01e](73cf01e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com> Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
npalm
pushed a commit
that referenced
this pull request
Oct 4, 2025
This PR will replace:
```hcl
cpu_options {
core_count = var.cpu_options != null ? var.cpu_options.core_count : null
threads_per_core = var.cpu_options != null ? var.cpu_options.threads_per_core : null
}
```
with:
```hcl
dynamic "cpu_options" {
for_each = var.cpu_options != null ? [var.cpu_options] : []
content {
core_count = try(cpu_options.value.core_count, null)
threads_per_core = try(cpu_options.value.threads_per_core, null)
}
}
```
This way, if `cpu_options` is not set, Terraform will **not force a
resource update every time**.
This issue was introduced in PR #4789
<img width="346" height="94" alt="image"
src="https://github.com/user-attachments/assets/5a3ca60d-7300-4957-91c3-ff87c2cd5b62"
/>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
This PR adds a feature which enables to use of `cpu_options` in the runner config. Context: We have a workload where hyperthreading hurts performance. With this option, we can opt-out of hyperthreading for a certain runner configuration. Tested by applying to our internal dev infra. Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [6.8.0](github-aws-runners/terraform-aws-github-runner@v6.7.9...v6.8.0) (2025-10-03) ### Features * add cpu_options for EC2 launch template ([github-aws-runners#4789](github-aws-runners#4789)) ([20eeead](github-aws-runners@20eeead)) @kirschem-fernride ### Bug Fixes * **lambda:** bump the aws group across 1 directory with 7 updates ([github-aws-runners#4805](github-aws-runners#4805)) ([3025930](github-aws-runners@3025930)) * **lambda:** bump the octokit group in /lambdas with 3 updates ([github-aws-runners#4794](github-aws-runners#4794)) ([73cf01e](github-aws-runners@73cf01e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com> Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
…s-runners#4806) This PR will replace: ```hcl cpu_options { core_count = var.cpu_options != null ? var.cpu_options.core_count : null threads_per_core = var.cpu_options != null ? var.cpu_options.threads_per_core : null } ``` with: ```hcl dynamic "cpu_options" { for_each = var.cpu_options != null ? [var.cpu_options] : [] content { core_count = try(cpu_options.value.core_count, null) threads_per_core = try(cpu_options.value.threads_per_core, null) } } ``` This way, if `cpu_options` is not set, Terraform will **not force a resource update every time**. This issue was introduced in PR github-aws-runners#4789 <img width="346" height="94" alt="image" src="https://github.com/user-attachments/assets/5a3ca60d-7300-4957-91c3-ff87c2cd5b62" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature which enables to use of
cpu_optionsin the runner config.Context: We have a workload where hyperthreading hurts performance. With this option, we can opt-out of hyperthreading for a certain runner configuration.
Tested by applying to our internal dev infra.