Repository navigation
Conversation
Author
|
Hi @decyjphr, CI and CodeQL are green on this one. Gentle nudge, no rush, just making sure it is on your radar. Thanks for maintaining safe-settings! |
3rwww1
force-pushed
the
fix/paginate-pull-request-files
branch
from
October 14, 2026 00:01
1bd76e1 to
20f146d
Compare
Signed-off-by: Erwan Queffélec <airone.k@gmail.com>
Author
|
Rebased on main and fixed the unit test mock for the paginated file listing. Could a maintainer approve the workflow run so CI can check the new head? Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pulls.listFilesis called without pagination, so the API default of 30 applies..github/repos/gets a partial preview. When no safe-settings config file lands on that first page, the check run saysNumber of repos that were considered: 0and concludes success..github/settings.ymlfull-sync check,getChangedRepoConfigNameandgetChangedSubOrgConfigNameall miss anything past page one.Fix
per_page: 100. Five lines inindex.js, andoctokit.paginateis already used here forapps.listInstallations.Test
test/unit/index.test.jsisdescribe.skip('plugin', ...)in its entirety, so a new case there would never run, and none of its cases cover thecheck_run.createdpath.Fixes #1080