Skip to content

Ignore has_downloads when comparing repository settings - #1114

Open
ahilsend wants to merge 1 commit into
github-community-projects:main-enterprisefrom
ahilsend:ignore-has-downloads
Open

ahilsend wants to merge 1 commit into
github-community-projects:main-enterprisefrom
ahilsend:ignore-has-downloads

Conversation

@ahilsend

Copy link
Copy Markdown

GitHub retired repository Downloads, and the API now always returns has_downloads: false, even right after you set it to true. So if settings.yml has has_downloads: true, the compare never matches and every sync updates the repository again.

We hit this with a 5 minute cron: every run updated every repository and re-sent the Dependabot security fixes call, which filled our org audit log with repo.change_merge_setting and repository_security_updates.enable events from the app, around 1,300 an hour.

This adds has_downloads to the fields the repository plugin ignores when comparing, with a test that a repository whose only difference is has_downloads is not updated.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GBoD4jBkEnE8FQJb5WYa1p

GitHub retired repository Downloads. The API always returns has_downloads:
false, even right after it is set to true. So a settings.yml with
has_downloads: true never matches, and every sync updates the repository
again. With a cron sync that is an update, plus the Dependabot security fixes
call, on every repository every run, and an audit log full of
repo.change_merge_setting and repository_security_updates.enable events.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBoD4jBkEnE8FQJb5WYa1p

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant