Repository navigation
[GHSA-4xw9-cx39-r355] json-web-token library is vulnerable to a JWT algorithm confusion attack - #9708
Conversation
|
Hi there @joaquimserafim! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The advisory metadata now accurately covers affected versions, with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects the advisory’s affected range to include all vulnerable json-web-token versions before 4.0.0.
Changes:
- Removes the outdated
<= 3.1.1affected-version limit. - Updates the modification timestamp.
| File | Description |
|---|---|
advisories/github-reviewed/2023/11/GHSA-4xw9-cx39-r355/GHSA-4xw9-cx39-r355.json |
Corrects affected-version metadata while retaining 4.0.0 as the fixed version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4049d5e
into
nikpivkin/advisory-improvement-9708
|
Hi @nikpivkin! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Updates
Comments
The range should end at < 4.0.0, not <= 3.1.1. Version 3.2.0 came out after 3.1.1 and does not have the fix.
The fix joaquimserafim/json-web-token@b6e56b1 is in tag v4.0.0 and not in tag v3.1.1. The repository has no tag for 3.2.0, so I checked the npm package, and it still has the old algorithm handling in index.js.
So version 3.2.0 is still vulnerable but is outside the current range.