isEffectiveSink can't be final because ExtractMisclassifiedEndpointFeatures overrides it.

tiferet · tiferet · commit 38c40a719206 · 2022-11-16T12:12:50.000-08:00
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll b/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll
@@ -69,7 +69,7 @@ abstract class AtmConfig extends string {
    * Holds if the candidate sink `candidateSink` predicted by the machine learning model should be
    * an effective sink, i.e. one considered as a possible sink of flow in the boosted query.
    */
-  final predicate isEffectiveSink(JS::DataFlow::Node candidateSink) {
+  predicate isEffectiveSink(JS::DataFlow::Node candidateSink) {
     not exists(this.getAReasonSinkExcluded(candidateSink))
   }
 

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ abstract class AtmConfig extends string {`
`69`	`69`	* Holds if the candidate sink `candidateSink` predicted by the machine learning model should be
`70`	`70`	`* an effective sink, i.e. one considered as a possible sink of flow in the boosted query.`
`71`	`71`	`*/`
`72`		`- final predicate isEffectiveSink(JS::DataFlow::Node candidateSink) {`
	`72`	`+ predicate isEffectiveSink(JS::DataFlow::Node candidateSink) {`
`73`	`73`	`not exists(this.getAReasonSinkExcluded(candidateSink))`
`74`	`74`	`}`
`75`	`75`