JS: Update ExternalAPIUsedwithUntrustedData

asgerf · asgerf · commit 7c29ea9dda61 · 2025-01-20T11:20:32.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll
@@ -33,11 +33,7 @@ module ExternalAPIUsedWithUntrustedDataConfig implements DataFlow::ConfigSig {
   }
 
   predicate observeDiffInformedIncrementalMode() {
-    // TODO(diff-informed): Manually verify if config can be diff-informed.
-    // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:96: Flow call outside 'select' clause
-    // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:99: Flow call outside 'select' clause
-    // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:109: Flow call outside 'select' clause
-    none()
+    none() // Not used for PR analysis
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,7 @@ module ExternalAPIUsedWithUntrustedDataConfig implements DataFlow::ConfigSig {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`predicate observeDiffInformedIncrementalMode() {`
`36`		`- // TODO(diff-informed): Manually verify if config can be diff-informed.`
`37`		`- // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:96: Flow call outside 'select' clause`
`38`		`- // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:99: Flow call outside 'select' clause`
`39`		`- // ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataQuery.qll:109: Flow call outside 'select' clause`
`40`		`- none()`
	`36`	`+ none() // Not used for PR analysis`
`41`	`37`	`}`
`42`	`38`	`}`
`43`	`39`