JS: Update DifferentKindsComparisonBypassQuery.qll

asgerf · asgerf · commit ecbd7983ba92 · 2025-01-20T11:20:31.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll
@@ -22,10 +22,7 @@ private module DifferentKindsComparisonBypassConfig implements DataFlow::ConfigS
   predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
 
   predicate observeDiffInformedIncrementalMode() {
-    // TODO(diff-informed): Manually verify if config can be diff-informed.
-    // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:39: Flow call outside 'select' clause
-    // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:40: Flow call outside 'select' clause
-    none()
+    none() // Disabled since multiple related sinks are selected simultaneously
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,10 +22,7 @@ private module DifferentKindsComparisonBypassConfig implements DataFlow::ConfigS`
`22`	`22`	`predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }`
`23`	`23`
`24`	`24`	`predicate observeDiffInformedIncrementalMode() {`
`25`		`- // TODO(diff-informed): Manually verify if config can be diff-informed.`
`26`		`- // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:39: Flow call outside 'select' clause`
`27`		`- // ql/lib/semmle/javascript/security/dataflow/DifferentKindsComparisonBypassQuery.qll:40: Flow call outside 'select' clause`
`28`		`- none()`
	`25`	`+ none() // Disabled since multiple related sinks are selected simultaneously`
`29`	`26`	`}`
`30`	`27`	`}`
`31`	`28`