C++: SSLResultConflation

Author: d10c

cpp/ql/src/Security/CWE/CWE-295/SSLResultConflation.ql

@@ -32,12 +32,12 @@ module VerifyResultConfig implements DataFlow::ConfigSig {
     exists(GuardCondition guard | guard.getAChild*() = sink.asExpr())
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 42 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-295/SSLResultConflation.ql@48:8:48:12), Column 1 does not select a source or sink originating from the flow call on line 43 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-295/SSLResultConflation.ql@48:8:48:12)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 42 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-295/SSLResultConflation.ql@48:8:48:12), Column 1 does not select a source or sink originating from the flow call on line 43 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-295/SSLResultConflation.ql@48:8:48:12)
+    exists(GuardCondition guard | result = guard.getLocation() |
+      guard.comparesEq(sink.asExpr(), _, 0, false, _)
+    )
   }
 }