Python: ObjectAPI to ValueAPI: WrongNumberArgumentsInCall: Exceptions.qll: Fixes incorrect implementation of localRaisedType

BekaValentine · BekaValentine · commit f25428b7a9f8 · 2020-04-03T20:08:00.000-07:00
diff --git a/python/ql/src/semmle/python/types/Exceptions.qll b/python/ql/src/semmle/python/types/Exceptions.qll
@@ -97,7 +97,7 @@ class RaisingNode extends ControlFlowNode {
         (
             exists(ControlFlowNode ex |
                 ex = this.getExceptionNode() and
-                (ex.pointsTo(result) or ex.pointsTo(_, result, _))
+                (ex.pointsTo(result) or ex.pointsTo().getClass() = result)
             )
             or
             this.getNode() instanceof ImportExpr and result = ClassValue::importError()

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class RaisingNode extends ControlFlowNode {`
`97`	`97`	`(`
`98`	`98`	`exists(ControlFlowNode ex \|`
`99`	`99`	`ex = this.getExceptionNode() and`
`100`		`- (ex.pointsTo(result) or ex.pointsTo(_, result, _))`
	`100`	`+ (ex.pointsTo(result) or ex.pointsTo().getClass() = result)`
`101`	`101`	`)`
`102`	`102`	`or`
`103`	`103`	`this.getNode() instanceof ImportExpr and result = ClassValue::importError()`