C++: CleartextBufferWrite

d10c · d10c · commit fd0d513093e9 · 2025-07-11T14:42:30.000+02:00
diff --git a/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql b/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql
@@ -48,8 +48,10 @@ module ToBufferConfig implements DataFlow::ConfigSig {
 
   predicate isSink(DataFlow::Node sink) { isSinkImpl(sink, _) }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 62 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql@65:8:65:8)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSinkLocation(DataFlow::Node sink) {
+    exists(SensitiveBufferWrite w | result = w.getLocation() | isSinkImpl(sink, w))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,10 @@ module ToBufferConfig implements DataFlow::ConfigSig {`
`48`	`48`
`49`	`49`	`predicate isSink(DataFlow::Node sink) { isSinkImpl(sink, _) }`
`50`	`50`
`51`		`- predicate observeDiffInformedIncrementalMode() {`
`52`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 62 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql@65:8:65:8)`
	`51`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`52`	`+`
	`53`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) {`
	`54`	`+ exists(SensitiveBufferWrite w \| result = w.getLocation() \| isSinkImpl(sink, w))`
`53`	`55`	`}`
`54`	`56`	`}`
`55`	`57`