Skip to content

Python: Add jump-to-def tests for unpacking assignments #20303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Aug 28, 2025
Merged

Python: Add jump-to-def tests for unpacking assignments #20303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/ql/test/query-tests/analysis/jump_to_defn/Definitions.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@
| test.py:44:8:44:14 | ImportExpr | package/__init__.py:0:0:0:0 | Definition package/__init__.py:0 | Definition |
| test.py:45:1:45:1 | p | test.py:44:8:44:14 | Definition test.py:44 | Definition |
| test.py:45:3:45:3 | Attribute | package/__init__.py:2:18:2:18 | Definition package/__init__.py:2 | Definition |
| test.py:48:32:48:38 | dirname | test.py:47:9:47:15 | Definition test.py:47 | Definition |
| test.py:50:34:50:38 | lines | test.py:47:18:47:22 | Definition test.py:47 | Definition |
| test.py:53:12:53:12 | x | test.py:49:9:49:12 | Definition test.py:49 | Definition |
8 changes: 8 additions & 0 deletions python/ql/test/query-tests/analysis/jump_to_defn/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,11 @@ class Decorated(object):
from package import x
import package as p
p.x

def foo(dirname, lines):
head, tail = os.path.split(dirname)
x = head # `head` is missing jump-to-def target
for start, line in enumerate(lines):
line = line.strip() # `line` is missing jump-to-def target
break
return x