Repository navigation
[WIP] Fix failing GitHub Actions job license-check - #3490
Open
IrynaKulakova with Copilot wants to merge 3 commits into
Open
IrynaKulakova with Copilot wants to merge 3 commits into
IrynaKulakova with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: IrynaKulakova <52420926+IrynaKulakova@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The referenced job’s license-report inconsistency remains unresolved and still triggers the final failure gate.
1 open issue
What changed in this PR
Makes license-check notifications best-effort while preserving license enforcement.
Changes:
- Tolerates failures when checking or posting comments.
- Attempts posting unless an existing comment is confirmed.
| File | Description |
|---|---|
.github/workflows/license-check.yml |
Makes notification failures nonfatal and broadens the posting condition. |
Review effort: Max
| - name: Comment with instructions if cannot push | ||
| if: steps.changes.outcome == 'failure' && steps.push.outcome == 'failure' && steps.check_comment.outputs.already_commented == 'false' | ||
| if: steps.changes.outcome == 'failure' && steps.push.outcome == 'failure' && steps.check_comment.outputs.already_commented != 'true' | ||
| continue-on-error: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.