Repository navigation
fix: schedule automatic updates for the Unix epoch - #389
Merged
liuliu-dev merged 1 commit intoOct 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves date validation, and the regression verifies the corrected scheduling behavior.
No open issues 🎉
What changed in this PR
Fixes automatic updates for <relative-time> elements whose date is the Unix epoch.
Changes:
- Accepts timestamp
0when scheduling updates while preserving invalid-date handling. - Adds a regression test verifying a scheduled duration update from five to six seconds.
| File | Description |
|---|---|
| test/relative-time.js | Tests scheduled updates for the Unix epoch. |
| src/relative-time-element.ts | Removes the guard that incorrectly rejects timestamp 0. |
Review effort: Max
liuliu-dev
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A duration with
datetime="1970-01-01T00:00:00.000Z"renders its initial value but does not schedule automatic updates. The observer treats the valid timestamp0as a missing date.Schedule updates for every valid date returned by the existing getter. The regression starts at five seconds after the epoch, runs the scheduled tick, and checks that the duration becomes six seconds.
Validation: the regression did not receive a scheduled tick before the fix; all 636 Chromium tests pass afterward. Full TypeScript, ESLint, ESM/bundle and element-manifest builds pass on Node 24. Tests use the repository's Dubai time zone with an explicit English browser locale. The Windows cleanup hook was skipped and the same lint/build tools were run directly; Firefox and WebKit were not run.