Repository navigation
ci: run affected suites and guide meaningful test coverage - #14
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9dd112c2-7eb9-443c-bc31-37cb9c3a663e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9dd112c2-7eb9-443c-bc31-37cb9c3a663e
There was a problem hiding this comment.
🟡 Changes recommended
Suite selection excludes starter inputs consumed by Hub, allowing local-setup regressions to bypass the relevant checks.
2 open findings
What changed in this PR
Reduces unrelated Hub and build-action CI work in Replica and introduces guidance for meaningful test coverage.
Changes:
- Selects affected suites while preserving required check names and full suites on
main. - Adds selector coverage and workflow-guard validation.
- Adds test-writing guidance and removes redundant assertions.
| File | Description |
|---|---|
| scripts/select-ci-suites.test.mjs | Tests path selection, Git diffs, and CLI behavior. |
| scripts/select-ci-suites.mjs | Maps changed paths to affected suites. |
| scripts/create-prototype-repo.test.mjs | Removes repeated starter-content checks. |
| scripts/check-ci-workflows.rb | Validates workflow wiring and result guards. |
| hub/docs/testing-and-operations.md | Explains conditional Hub CI execution. |
| hub/app/javascript/pages/welcome-page/index.test.tsx | Removes exact SVG-count assertions. |
| docs/testing-and-review.md | Documents test quality and suite selection. |
| AGENTS.md | Links the test-writing skill. |
| .github/workflows/hub-ci.yml | Gates Hub work on suite selection. |
| .github/workflows/ci-changes.yml | Adds reusable suite selection. |
| .github/workflows/actions-ci.yml | Gates build-action work and preserves its required check. |
| .github/skills/write-tests/SKILL.md | Adds contract-first test-writing guidance. |
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9dd112c2-7eb9-443c-bc31-37cb9c3a663e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hub and build-action checks currently run for unrelated pull requests. Some existing assertions also repeat coverage or freeze visual implementation details rather than protect behavior.
What changes
Pull requests select whole Hub and build-action suites from their changed paths, including shared dependencies. Unknown paths run both suites, and pushes to main retain both complete suites. Existing required check names remain available, and the final checks reject failed selection or missing results. Dependency-age checks and the Starter and Learning workflows remain unchanged.
A shared test-writing skill asks agents to justify distinct regression coverage and use an independent test writer for substantial behavior changes and nontrivial fixes. The change also removes exact SVG-count assertions and repeated starter-content validation while retaining behavioral and copy checks.
Actual GitHub skipping and required-check reporting remain unverified. This PR should run both full suites because it changes workflows; a separate docs-only PR based on this branch is needed to exercise the skipped-suite path.