Skip to content

Avoid duplicate check listeners after reconnecting #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuliu-dev merged 2 commits into from
Oct 19, 2026
Merged

Avoid duplicate check listeners after reconnecting #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bddda0
Avoid duplicate check listeners after reconnecting
feritcemkahraman Oct 18, 2026
848264d
Merge branch 'main' into fix/avoid-duplicate-check-listeners
liuliu-dev Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions src/task-lists-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,24 @@ import {SortEndArgs, isDragging, sortable} from './sortable'
const observers = new WeakMap()

export default class TaskListsElement extends HTMLElement {
connectedCallback(): void {
this.addEventListener('change', (event: Event) => {
const checkbox = event.target
if (!(checkbox instanceof HTMLInputElement)) return
if (!checkbox.classList.contains('task-list-item-checkbox')) return

this.dispatchEvent(
new CustomEvent('task-lists-check', {
bubbles: true,
detail: {
position: position(checkbox),
checked: checkbox.checked
}
})
)
})
handleEvent(event: Event): void {
const checkbox = event.target
if (!(checkbox instanceof HTMLInputElement)) return
if (!checkbox.classList.contains('task-list-item-checkbox')) return

this.dispatchEvent(
new CustomEvent('task-lists-check', {
bubbles: true,
detail: {
position: position(checkbox),
checked: checkbox.checked
}
})
)
}

connectedCallback(): void {
this.addEventListener('change', this)
const observer = new MutationObserver(syncState.bind(null, this))
observers.set(this, observer)

Expand Down
23 changes: 23 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,29 @@ describe('task-lists element', function () {
document.body.innerHTML = ''
})

it('emits one check event per change after reconnecting', function () {
const list = document.querySelector('task-lists')
const parent = list.parentElement
list.remove()
parent.append(list)
list.remove()
parent.append(list)
const events = []
list.addEventListener('task-lists-check', event => events.push(event.detail))
const checkbox = list.querySelector('.task-list-item-checkbox')

checkbox.checked = true
checkbox.dispatchEvent(new Event('change', {bubbles: true}))
assert.deepEqual(events, [{position: [0, 0], checked: true}])

checkbox.checked = false
checkbox.dispatchEvent(new Event('change', {bubbles: true}))
assert.deepEqual(events, [
{position: [0, 0], checked: true},
{position: [0, 0], checked: false}
])
})

it('emits check event with position', function () {
let called = false

Expand Down