Skip to content

Preserve explicitly configured zero typing delays #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuliu-dev merged 2 commits into from
Oct 20, 2026
+28 −2
Merged

Preserve explicitly configured zero typing delays #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a6befc
Preserve explicitly configured zero typing delays
feritcemkahraman Oct 17, 2026
5b76ba6
fix: preserve whitespace delay defaults
feritcemkahraman Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class TypingEffectElement extends HTMLElement {
if (this.prefersReducedMotion) {
return 0
}
return Math.max(0, Math.min(Math.floor(Number(this.getAttribute('data-character-delay'))), 2_147_483_647)) || 40
const delay = Number(this.getAttribute('data-character-delay')?.trim() || 40)
if (delay === 0) return 0
return Math.max(0, Math.min(Math.floor(delay), 2_147_483_647)) || 40
}

set characterDelay(value: number) {
Expand All @@ -61,7 +63,9 @@ class TypingEffectElement extends HTMLElement {
if (this.prefersReducedMotion) {
return 0
}
return Math.max(0, Math.min(Math.floor(Number(this.getAttribute('data-line-delay'))), 2_147_483_647)) || 40
const delay = Number(this.getAttribute('data-line-delay')?.trim() || 40)
if (delay === 0) return 0
return Math.max(0, Math.min(Math.floor(delay), 2_147_483_647)) || 40
}

set lineDelay(value: number) {
Expand Down
22 changes: 22 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,28 @@ describe('typing-effect', function () {
assert.equal(typingEffectElement.lineDelay, 40)
})

it('preserves zero delay attributes and property values', function () {
const element = document.createElement('typing-effect')
element.setAttribute('data-character-delay', '0')
element.setAttribute('data-line-delay', '0')
assert.strictEqual(element.characterDelay, 0)
assert.strictEqual(element.lineDelay, 0)

element.characterDelay = 20
element.lineDelay = 20
element.characterDelay = 0
element.lineDelay = 0
assert.strictEqual(element.characterDelay, 0)
assert.strictEqual(element.lineDelay, 0)

for (const value of ['', ' ', '\n', '0.5']) {
element.setAttribute('data-character-delay', value)
element.setAttribute('data-line-delay', value)
assert.strictEqual(element.characterDelay, 40)
assert.strictEqual(element.lineDelay, 40)
}
})

it('uses specified delay attributes instead of using defaults', function () {
const characterDelay = 20
const lineDelay = 20
Expand Down
Loading