Skip to content

Commit 2dbc50e

Browse files
committed
Remove use of extLogger from generate model queries
1 parent 5c2050d commit 2dbc50e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

extensions/ql-vscode/src/model-editor/generate-model-queries.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ import { DatabaseItem } from "../databases/local-databases";
33
import { QueryRunner } from "../query-server";
44
import { CodeQLCliServer } from "../codeql-cli/cli";
55
import {
6-
BaseLogger,
6+
NotificationLogger,
77
showAndLogExceptionWithTelemetry,
88
} from "../common/logging";
9-
import { extLogger } from "../common/logging/vscode";
109
import { getModelsAsDataLanguage } from "./languages";
1110
import { ProgressCallback } from "../common/vscode/progress";
1211
import { getOnDiskWorkspaceFolders } from "../common/vscode/workspace-folders";
@@ -27,7 +26,7 @@ export function isGenerateModelSupported(language: QueryLanguage): boolean {
2726
type GenerateModelOptions = {
2827
cliServer: CodeQLCliServer;
2928
queryRunner: QueryRunner;
30-
logger: BaseLogger;
29+
logger: NotificationLogger;
3130
queryStorageDir: string;
3231
databaseItem: DatabaseItem;
3332
language: QueryLanguage;
@@ -54,7 +53,11 @@ export async function runGenerateModelQuery({
5453
maxStep,
5554
});
5655

57-
const queryPath = await resolveGenerateModelQuery(cliServer, databaseItem);
56+
const queryPath = await resolveGenerateModelQuery(
57+
cliServer,
58+
logger,
59+
databaseItem,
60+
);
5861
if (queryPath === undefined) {
5962
return [];
6063
}
@@ -133,6 +136,7 @@ export async function runGenerateModelQuery({
133136

134137
async function resolveGenerateModelQuery(
135138
cliServer: CodeQLCliServer,
139+
logger: NotificationLogger,
136140
databaseItem: DatabaseItem,
137141
): Promise<string | undefined> {
138142
const packsToSearch = [`codeql/${databaseItem.language}-queries`];
@@ -147,7 +151,7 @@ async function resolveGenerateModelQuery(
147151
);
148152
if (queries.length !== 1) {
149153
void showAndLogExceptionWithTelemetry(
150-
extLogger,
154+
logger,
151155
telemetryListener,
152156
redactableError`Expected exactly one generate model query, got ${queries.length}`,
153157
);

0 commit comments

Comments
 (0)