Pull out props to separate variables instead of referencing props.foo

Author: robertbrignull

extensions/ql-vscode/src/view/model-editor/HiddenMethodsRow.tsx

@@ -14,16 +14,19 @@ interface Props {
   someMethodsAreVisible: boolean;
 }
 
-export function HiddenMethodsRow(props: Props) {
-  if (props.numHiddenMethods === 0) {
+export function HiddenMethodsRow({
+  numHiddenMethods,
+  someMethodsAreVisible,
+}: Props) {
+  if (numHiddenMethods === 0) {
     return null;
   }
 
   return (
     <VSCodeDataGridRow>
       <HiddenMethodsCell gridColumn="span 5">
-        {props.someMethodsAreVisible && "And "}
-        {props.numHiddenMethods} methods modeled in other CodeQL packs
+        {someMethodsAreVisible && "And "}
+        {numHiddenMethods} methods modeled in other CodeQL packs
       </HiddenMethodsCell>
     </VSCodeDataGridRow>
   );

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

@@ -71,7 +71,9 @@ type Props = {
 };
 
 export const MethodRow = (props: Props) => {
-  if (props.methodCanBeModeled) {
+  const { methodCanBeModeled } = props;
+
+  if (methodCanBeModeled) {
     return <ModelableMethodRow {...props} />;
   } else {
     return <UnmodelableMethodRow {...props} />;