Map enum properly

Author: norascheuch

extensions/ql-vscode/src/variant-analysis/store/repo-states-data-types.ts

@@ -1,7 +1,12 @@
-import { VariantAnalysisScannedRepositoryDownloadStatus } from "../shared/variant-analysis";
-
 export interface VariantAnalysisScannedRepositoryStateData {
   repositoryId: number;
-  downloadStatus: VariantAnalysisScannedRepositoryDownloadStatus;
+  downloadStatus: VariantAnalysisScannedRepositoryDownloadData;
   downloadPercentage?: number;
 }
+
+export enum VariantAnalysisScannedRepositoryDownloadData {
+  Pending = "pending",
+  InProgress = "inProgress",
+  Succeeded = "succeeded",
+  Failed = "failed",
+}

extensions/ql-vscode/src/variant-analysis/store/repo-states-store.ts

@@ -1,6 +1,8 @@
 import { outputJson, readJson } from "fs-extra";
 import { VariantAnalysisScannedRepositoryState } from "../shared/variant-analysis";
 import { VariantAnalysisScannedRepositoryStateData } from "./repo-states-data-types";
+import { mapRepoStateToData } from "./repo-states-to-data-mapper";
+import { mapRepoStateToDomain } from "./repo-states-to-domain-mapper";
 
 export const REPO_STATES_FILENAME = "repo_states.json";
 
@@ -11,8 +13,7 @@ export async function writeRepoStates(
   // Map from repoStates Domain type to the repoStates Data type
   const repoStatesData = Object.fromEntries(
     Object.entries(repoStates).map(([key, value]) => {
-      const dataItem: VariantAnalysisScannedRepositoryStateData = value;
-      return [key, dataItem];
+      return [key, mapRepoStateToData(value)];
     }),
   );
 
@@ -30,8 +31,7 @@ export async function readRepoStates(
   // Map from repoStates Data type to the repoStates Domain type
   const repoStates = Object.fromEntries(
     Object.entries(repoStatesData).map(([key, value]) => {
-      const dataItem: VariantAnalysisScannedRepositoryState = value;
-      return [key, dataItem];
+      return [key, mapRepoStateToDomain(value)];
     }),
   );
 

extensions/ql-vscode/src/variant-analysis/store/repo-states-to-data-mapper.ts

@@ -0,0 +1,35 @@
+import {
+  VariantAnalysisScannedRepositoryDownloadStatus,
+  VariantAnalysisScannedRepositoryState,
+} from "../shared/variant-analysis";
+import {
+  VariantAnalysisScannedRepositoryDownloadData,
+  VariantAnalysisScannedRepositoryStateData,
+} from "./repo-states-data-types";
+
+export function mapRepoStateToData(
+  repoState: VariantAnalysisScannedRepositoryState,
+): VariantAnalysisScannedRepositoryStateData {
+  return {
+    repositoryId: repoState.repositoryId,
+    downloadStatus: processDownloadStatus(repoState.downloadStatus),
+    downloadPercentage: repoState.downloadPercentage,
+  };
+}
+
+function processDownloadStatus(
+  downloadedStatus: VariantAnalysisScannedRepositoryDownloadStatus,
+) {
+  switch (downloadedStatus) {
+    case VariantAnalysisScannedRepositoryDownloadStatus.Pending:
+      return VariantAnalysisScannedRepositoryDownloadData.Pending;
+    case VariantAnalysisScannedRepositoryDownloadStatus.InProgress:
+      return VariantAnalysisScannedRepositoryDownloadData.InProgress;
+    case VariantAnalysisScannedRepositoryDownloadStatus.Succeeded:
+      return VariantAnalysisScannedRepositoryDownloadData.Succeeded;
+    case VariantAnalysisScannedRepositoryDownloadStatus.Failed:
+      return VariantAnalysisScannedRepositoryDownloadData.Failed;
+    default:
+      return VariantAnalysisScannedRepositoryDownloadData.Pending;
+  }
+}

extensions/ql-vscode/src/variant-analysis/store/repo-states-to-domain-mapper.ts

@@ -0,0 +1,35 @@
+import {
+  VariantAnalysisScannedRepositoryState,
+  VariantAnalysisScannedRepositoryDownloadStatus,
+} from "../shared/variant-analysis";
+import {
+  VariantAnalysisScannedRepositoryStateData,
+  VariantAnalysisScannedRepositoryDownloadData,
+} from "./repo-states-data-types";
+
+export function mapRepoStateToDomain(
+  repoState: VariantAnalysisScannedRepositoryStateData,
+): VariantAnalysisScannedRepositoryState {
+  return {
+    repositoryId: repoState.repositoryId,
+    downloadStatus: processDownloadStatus(repoState.downloadStatus),
+    downloadPercentage: repoState.downloadPercentage,
+  };
+}
+
+function processDownloadStatus(
+  downloadedStatus: VariantAnalysisScannedRepositoryDownloadData,
+) {
+  switch (downloadedStatus) {
+    case VariantAnalysisScannedRepositoryDownloadData.Pending:
+      return VariantAnalysisScannedRepositoryDownloadStatus.Pending;
+    case VariantAnalysisScannedRepositoryDownloadData.InProgress:
+      return VariantAnalysisScannedRepositoryDownloadStatus.InProgress;
+    case VariantAnalysisScannedRepositoryDownloadData.Succeeded:
+      return VariantAnalysisScannedRepositoryDownloadStatus.Succeeded;
+    case VariantAnalysisScannedRepositoryDownloadData.Failed:
+      return VariantAnalysisScannedRepositoryDownloadStatus.Failed;
+    default:
+      return VariantAnalysisScannedRepositoryDownloadStatus.Pending;
+  }
+}