Skip to content

Commit 57241c9

Browse files
Convert onTableSelectionChange to use useCallback
1 parent ee20a28 commit 57241c9

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

extensions/ql-vscode/src/view/results/ResultTables.tsx

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -182,17 +182,18 @@ export function ResultTables(props: ResultTablesProps) {
182182
}
183183
}, [parsedResultSets, interpretation, rawResultSets, selectedTable]);
184184

185-
const onTableSelectionChange = (
186-
event: React.ChangeEvent<HTMLSelectElement>,
187-
): void => {
188-
const selectedTable = event.target.value;
189-
vscode.postMessage({
190-
t: "changePage",
191-
pageNumber: 0,
192-
selectedTable,
193-
});
194-
sendTelemetry("local-results-table-selection");
195-
};
185+
const onTableSelectionChange = useCallback(
186+
(event: React.ChangeEvent<HTMLSelectElement>): void => {
187+
const selectedTable = event.target.value;
188+
vscode.postMessage({
189+
t: "changePage",
190+
pageNumber: 0,
191+
selectedTable,
192+
});
193+
sendTelemetry("local-results-table-selection");
194+
},
195+
[],
196+
);
196197

197198
const alertTableExtras = (): JSX.Element | undefined => {
198199
const handleCheckboxChanged = (e: React.ChangeEvent<HTMLInputElement>) => {

0 commit comments

Comments
 (0)