Skip to content

Commit ee20a28

Browse files
Add dependencies to useEffect hooks
1 parent d173ff3 commit ee20a28

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

extensions/ql-vscode/src/view/results/ResultTables.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export function ResultTables(props: ResultTablesProps) {
164164
return () => {
165165
window.removeEventListener("message", vscodeMessageHandler);
166166
};
167-
}, []);
167+
}, [vscodeMessageHandler]);
168168

169169
useEffect(() => {
170170
const resultSetExists =
@@ -180,7 +180,7 @@ export function ResultTables(props: ResultTablesProps) {
180180
getDefaultResultSet(getResultSets(rawResultSets, interpretation)),
181181
);
182182
}
183-
});
183+
}, [parsedResultSets, interpretation, rawResultSets, selectedTable]);
184184

185185
const onTableSelectionChange = (
186186
event: React.ChangeEvent<HTMLSelectElement>,

0 commit comments

Comments
 (0)