Skip to content

Commit eb3900f

Browse files
committed
Bump minimum VS Code version for warnings
1 parent 3934ba7 commit eb3900f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

extensions/ql-vscode/src/extension.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,12 +299,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation";
299299

300300
const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE;
301301

302-
// This is the minimum version of vscode that we _want_ to support. We want to update the language server library, but that
303-
// requires 1.67 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode
302+
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 18, but that
303+
// requires 1.82 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
304304
// silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then
305305
// bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning
306306
// before silently being refused to upgrade.
307-
const MIN_VERSION = "1.67.0";
307+
const MIN_VERSION = "1.82.0";
308308

309309
/**
310310
* Returns the CodeQLExtensionInterface, or an empty object if the interface is not

0 commit comments

Comments
 (0)