Move handleCheckboxChanged out of alertTableExtras

Author: robertbrignull

extensions/ql-vscode/src/view/results/ResultTables.tsx

@@ -195,27 +195,27 @@ export function ResultTables(props: ResultTablesProps) {
     [],
   );
 
-  const alertTableExtras = (): JSX.Element | undefined => {
-    const handleCheckboxChanged = (e: React.ChangeEvent<HTMLInputElement>) => {
-      if (e.target.checked === problemsViewSelected) {
-        // no change
-        return;
-      }
-      setProblemsViewSelected(e.target.checked);
-      if (e.target.checked) {
-        sendTelemetry("local-results-show-results-in-problems-view");
-      }
-      if (resultsPath !== undefined) {
-        vscode.postMessage({
-          t: "toggleDiagnostics",
-          origResultsPaths,
-          databaseUri: database.databaseUri,
-          visible: e.target.checked,
-          metadata,
-        });
-      }
-    };
+  const handleCheckboxChanged = (e: React.ChangeEvent<HTMLInputElement>) => {
+    if (e.target.checked === problemsViewSelected) {
+      // no change
+      return;
+    }
+    setProblemsViewSelected(e.target.checked);
+    if (e.target.checked) {
+      sendTelemetry("local-results-show-results-in-problems-view");
+    }
+    if (resultsPath !== undefined) {
+      vscode.postMessage({
+        t: "toggleDiagnostics",
+        origResultsPaths,
+        databaseUri: database.databaseUri,
+        visible: e.target.checked,
+        metadata,
+      });
+    }
+  };
 
+  const alertTableExtras = (): JSX.Element | undefined => {
     return (
       <div className={alertExtrasClassName}>
         <div className={toggleDiagnosticsClassName}>