Merged
Conversation
koesie10
approved these changes
Jun 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the @types/node version in the integration tests with the Node version used by the latest VS Code release.
- Bumps
@types/nodefrom20.17.*to20.19.*inpackage.json.
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
| "@types/jest": "^29.5.12", | ||
| "@types/js-yaml": "^4.0.6", | ||
| "@types/node": "20.17.*", | ||
| "@types/node": "20.19.*", |
There was a problem hiding this comment.
[nitpick] Consider using a more specific version range (e.g., ^20.19.0) instead of a wildcard to ensure deterministic installs and consistent builds.
Suggested change
| "@types/node": "20.19.*", | |
| "@types/node": "^20.19.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node version used in the latest version of VS Code has been updated. This PR updates the Node version used for integration tests to match.
The previous Node version was v20.19.0. This PR updates the Node version to v20.19.0.