refactor: tidy up the forge adapter interface#2874
Open
afonsojramos wants to merge 8 commits intomainfrom
Open
refactor: tidy up the forge adapter interface#2874afonsojramos wants to merge 8 commits intomainfrom
afonsojramos wants to merge 8 commits intomainfrom
Conversation
setchy
reviewed
May 10, 2026
…r-interface # Conflicts: # src/renderer/routes/Accounts.tsx # src/renderer/utils/api/features.test.ts # src/renderer/utils/api/features.ts # src/renderer/utils/auth/utils.test.ts # src/renderer/utils/auth/utils.ts # src/renderer/utils/forges/gitea/adapter.test.ts # src/renderer/utils/forges/github/adapter.test.ts # src/renderer/utils/forges/github/client.ts # src/renderer/utils/system/links.test.ts
setchy
reviewed
May 10, 2026
| import { clearState, loadState, saveState } from '../utils/core/storage'; | ||
| import { | ||
| exchangeAuthCodeForAccessToken, | ||
| performGitHubWebOAuth, |
Member
There was a problem hiding this comment.
I'm not at a computer atm, but is there an alternate way for Apps to use the forge interface than GitHub forge specific imports?
Member
Author
There was a problem hiding this comment.
Yeah... That's fair, let me give this a try
Member
Author
There was a problem hiding this comment.
Take a look if it looks okay as is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three follow-up cleanups on top of the forge adapter interface, each as its own commit:
extractHostVersion,getGitHubAuthBaseUrl,getDeveloperSettingsURL,getNewTokenURL,getNewOAuthAppURL,isValidToken,isValidClientId) out of sharedauth/utils.tsand into a newforges/github/auth.ts. Tests followed.answeredDiscussioncapability from the sharedForgeCapabilitiescontract. It only ever drove GitHub GraphQL query construction, so it now lives privately assupportsAnsweredDiscussioninsideforges/github/capabilities.ts.isAnsweredDiscussionFeatureSupportedremoved fromapi/features.tsalong with the Gitea stub.getDeveloperSettingsUrl→getAccountSettingsUrlon theForgeAdapterinterface (andopenDeveloperSettings→openAccountSettingson the consumer). The "developer settings" wording was GitHub-flavoured; the new name reads cleanly for any forge.Test plan
pnpm exec tsc --noEmit— cleanpnpm exec biome checkon touched files — only pre-existing warningspnpm exec vitest --run— 1040/1040 passCloses #2873