Skip to content

refactor(main): adopt @gitify/menubar v10 for window/tray/system handling#2880

Open
afonsojramos wants to merge 6 commits into
mainfrom
adopt-gitify-menubar
Open

refactor(main): adopt @gitify/menubar v10 for window/tray/system handling#2880
afonsojramos wants to merge 6 commits into
mainfrom
adopt-gitify-menubar

Conversation

@afonsojramos
Copy link
Copy Markdown
Member

Summary

  • Swap the upstream menubar dependency for @gitify/menubar (v10) and lean on its built-in features.
  • Delegate window lifecycle (hideOnClose, escapeToHide, recenterOnTray), tray context-menu wiring/SNI refresh, and the global keyboard shortcut to the menubar instance.
  • Drop the now-redundant local glue in lifecycle/window.ts, handlers/tray.ts, and handlers/system.ts, simplifying tests accordingly.

@github-actions github-actions Bot added dependency Dependency updates refactor Refactoring of existing feature labels May 11, 2026
@sonarqubecloud
Copy link
Copy Markdown

@setchy
Copy link
Copy Markdown
Member

setchy commented May 11, 2026

These comments are more for @gitify/menubar

@setchy
Copy link
Copy Markdown
Member

setchy commented May 11, 2026

What do you think about a more universal package name such as electron-menubar vs @gitify/menubar.

We could also contribute a Renovate replacement rule which would help all the other consumers of max-mapper/menubar migration from the unmaintained v9 to v10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency Dependency updates refactor Refactoring of existing feature

Development

Successfully merging this pull request may close these issues.

2 participants