Repository navigation
fix(installer): update pywhispercpp for CUDA 13.3 - #247
Merged
Merged
Conversation
Pin pywhispercpp to the commit that updates whisper.cpp to v1.8.5. This restores CUDA source builds with CUDA 13.3, whose CCCL headers no longer expose the required iterator helpers transitively.\n\nUpstream-Fix: absadiki/pywhispercpp#174
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
|
Thank you very much @BestSithInEU ! Going to bump version now. |
Owner
|
Live in 1.43.0 🖖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f7bf62118c0a33a43cf8aabb58eef16cea5d16c4Problem
CUDA 13.3 no longer exposes
cuda::make_strided_iteratorandcuda::make_counting_iteratorthrough transitive CCCL includes. The previously pinned pywhispercpp commit bundles whisper.cpp v1.8.4, sohyprwhspr setupfails while compilingggml-cuda/argsort.cu.The updated pin contains the fix merged in absadiki/pywhispercpp#174. It was validated with CUDA 13.3.1 on an RTX 4080.
Validation
python -m unittest -v tests.test_dependency_plans tests.test_wheel_pipeline_and_defaults(57 passed)python -m unittest discover -s tests -v(756 passed)