Reintroduces the batch attestation cert command#781
Merged
Conversation
We can call `tools/configure.py` again to set the batch attestation private key and certificate. Also the AAGUID can now be passed in, instead of being part of customization. One only really makes sense with the other anyway.
|
Coverage is 97.269% — kaczmarczyck:vendor-command into google:develop. No base build found for |
ia0
previously approved these changes
Jun 4, 2026
Co-authored-by: Julien Cretin <github@ia0.eu>
ia0
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can call
tools/configure.pyagain to set the batch attestation private key and certificate.Also the AAGUID can now be passed in, instead of being part of customization. One only really makes sense with the other anyway.
Documentation is also update to reflect the state of batch attestation support: Fake if not configured, and real if configured. And the manual is written in a way that the privacy warning is hard to miss for anyone who runs the configure command.
Before random batch attestation, we had to send people towards the configure command more aggressively, since U2F only worked after configure was used. Now configure is actively discouraged since U2F just works without it. Only use it if you really want to build your own hardware security key and register it with FIDO.