fix: route HITL confirmation back to originating sub-agent in workflow agents#1229
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix: route HITL confirmation back to originating sub-agent in workflow agents#1229copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_921354317
branch
4 times, most recently
from
d741f6b to
d1cf34f
Compare
…w agents When an LlmAgent that uses a tool requiring Human-in-the-Loop confirmation is wrapped inside a non-LlmAgent workflow agent (e.g. SequentialAgent, ParallelAgent, LoopAgent), the runner used to fall back to the root agent on confirmation resumption. This caused 'VerifyException: Tool not found' because the root agent does not have the sub-agent's tools registered. Runner.findAgentToRun now first checks whether the last event is a function response and, if so, routes it back to the agent that emitted the matching function call (looked up by id), regardless of whether that agent's parent chain is fully transferable. This mirrors the Python ADK behaviour in Runner._find_agent_to_run via find_matching_function_call. PiperOrigin-RevId: 921354317
copybara-service
Bot
force-pushed
the
test_921354317
branch
from
d1cf34f to
6bc26df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: route HITL confirmation back to originating sub-agent in workflow agents
When an LlmAgent that uses a tool requiring Human-in-the-Loop confirmation
is wrapped inside a non-LlmAgent workflow agent (e.g. SequentialAgent,
ParallelAgent, LoopAgent), the runner used to fall back to the root agent
on confirmation resumption. This caused 'VerifyException: Tool not found'
because the root agent does not have the sub-agent's tools registered.
Runner.findAgentToRun now first checks whether the last event is a function
response and, if so, routes it back to the agent that emitted the matching
function call (looked up by id), regardless of whether that agent's parent
chain is fully transferable. This mirrors the Python ADK behaviour in
Runner._find_agent_to_run via find_matching_function_call.