Repository navigation
feat: support an optional direction on ct zone - #372
Open
bored-engineer wants to merge 1 commit into
Open
bored-engineer wants to merge 1 commit into
bored-engineer wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
"ct original zone set ..." and "ct reply zone set ..." carry
NFTA_CT_DIRECTION, but Ct only wrote it for CtKeyPKTS, CtKeyBYTES,
CtKeyAVGPKT, CtKeyL3PROTOCOL and CtKeyPROTOCOL (and then only with
OptDirection). A CtKeyZONE expression with Direction set silently lost
it, so the zone applied to both directions, and decoding a rule that had
a direction reported none.
Treat CtKeyZONE like those keys: with OptDirection the direction is
marshaled and unmarshaled, and without it nothing changes ("ct zone").
bored-engineer
force-pushed
the
ct-zone-direction
branch
from
October 18, 2026 18:08
ac1865a to
dd8b6cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ct only marshaled
NFTA_CT_DIRECTIONforCtKeyPKTS,CtKeyBYTES,CtKeyAVGPKT,CtKeyL3PROTOCOLandCtKeyPROTOCOL(and only withOptDirection). ACtKeyZONEexpression withDirectionset silently lost it, so "ct original zone set" came out as "ct zone set" and applied to both directions, and decoding a rule that had a direction reported none.This treats
CtKeyZONElike those keys: withOptDirectionthe direction is marshaled and unmarshaled, and without it nothing changes.