Repository navigation
fix: make masquerade to ports take effect, with its flags - #373
Open
bored-engineer wants to merge 1 commit into
Open
bored-engineer wants to merge 1 commit into
bored-engineer wants to merge 1 commit into
Conversation
Masq with ToPorts wrote the port registers but never set NF_NAT_RANGE_PROTO_SPECIFIED, which the kernel's masq expression needs to apply them (nft sets it too), so the range was ignored. It also only wrote NFTA_MASQ_FLAGS when ToPorts was false, so Random, FullyRandom and Persistent were dropped as soon as a range was set. Always write the flags that apply, and set PROTO_SPECIFIED with ToPorts. Masq without ToPorts is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MasqwithToPortswrote the port registers but never setNF_NAT_RANGE_PROTO_SPECIFIED, which the kernel's masq expression needs to apply them (nft sets it too), so the range was ignored. It also only wroteNFTA_MASQ_FLAGSwhenToPortswas false, soRandom,FullyRandomandPersistentwere dropped as soon as a range was set.Always write the flags that apply, and set
PROTO_SPECIFIEDwithToPorts.MasqwithoutToPortsis unchanged.