Skip to content

Forbid SHA-1 digests as part of RFC 9904 changes#3069

Open
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:9904
Open

Forbid SHA-1 digests as part of RFC 9904 changes#3069
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:9904

Conversation

@gbrodman
Copy link
Copy Markdown
Collaborator

@gbrodman gbrodman commented May 28, 2026

We can't change digest types that are already in the database but that's fine (since we just store them as integers). But we forbid them as part of domain creates/updates.


This change is Reviewable

@gbrodman gbrodman force-pushed the 9904 branch 3 times, most recently from 3196c22 to 52a2031 Compare May 29, 2026 17:25
@gbrodman gbrodman requested a review from CydeWeys May 29, 2026 17:31
Copy link
Copy Markdown
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 2 comments.
Reviewable status: 0 of 25 files reviewed, 2 unresolved discussions (waiting on gbrodman).


core/src/main/java/google/registry/flows/domain/DomainFlowUtils.java line 379 at r1 (raw file):

  }

  public static boolean algorithmIsInvalid(int alg) {

Curious as to why this was inverted?


core/src/main/java/google/registry/tools/DigestType.java line 32 at r1 (raw file):

 */
public enum DigestType {
  // Algorithm number 1 is SHA-1 and is deliberately NOT SUPPORTED.

We need to lock this change behind a FeatureFlag and send out notification 30 days ahead of time.

Copy link
Copy Markdown
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 2 comments.
Reviewable status: 0 of 25 files reviewed, 2 unresolved discussions (waiting on CydeWeys).


core/src/main/java/google/registry/flows/domain/DomainFlowUtils.java line 379 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Curious as to why this was inverted?

Suggested by IDEA, because all calls to it were immediately inverted.


core/src/main/java/google/registry/tools/DigestType.java line 32 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

We need to lock this change behind a FeatureFlag and send out notification 30 days ahead of time.

Done. We'll use the same feature flag for the algorithms too.

We can't change digest types that are already in the database but that's
fine (since we just store them as integers). But we forbid them as part
of domain creates/updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants