Fix a fuzzer failure by making sure array sizes aren't more than 1e6 bits.#4471
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fix a fuzzer failure by making sure array sizes aren't more than 1e6 bits.#4471copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…bits. This can happen in this simple case: ``` const too_big = -u32:19; const too_bit_array = sN[too_big]:-1; ``` Previously this attempted to create a bit array of almost 4e9 bits, which caused a compile-time core dump. Now, this is a type-checking-time error. PiperOrigin-RevId: 938109061
copybara-service
Bot
force-pushed
the
test_938109061
branch
from
a4bcaff to
a07ec19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a fuzzer failure by making sure array sizes aren't more than 1e6 bits.
This can happen in this simple case:
Previously this attempted to create a bit array of almost 4e9 bits,
which caused a compile-time core dump.
Now, this is a type-checking-time error.