Skip to content

test: restore and fix shadowed test_discovery_http_is_closed #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Capstan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: restore and fix shadowed test_discovery_http_is_closed #2758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions tests/test_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,12 +495,6 @@ def test_ResourceMethodParameters_zoo_animals_patch(self):
self.assertEqual(parameters.enum_params, {})


class Discovery(unittest.TestCase):
def test_discovery_http_is_closed(self):
http = HttpMock(datafile("malformed.json"), {"status": "200"})
service = build("plus", "v1", credentials=mock.sentinel.credentials)
http.close.assert_called_once()


class DiscoveryErrors(unittest.TestCase):
def test_tests_should_be_run_with_strict_positional_enforcement(self):
Expand Down Expand Up @@ -1535,6 +1529,25 @@ def test_file_based_cache(self):


class Discovery(unittest.TestCase):
@mock.patch("httplib2.Http")
def test_discovery_http_is_closed(self, mock_http_class):
discovery_mock_http = mock.Mock()
discovery_mock_http.redirect_codes = set()
service_mock_http = mock.Mock()
service_mock_http.redirect_codes = set()

discovery_mock_http.request.return_value = (
httplib2.Response({"status": "200"}),
read_datafile("plus.json"),
)

mock_http_class.side_effect = [discovery_mock_http, service_mock_http]

service = build("plus", "v1", static_discovery=False)

discovery_mock_http.close.assert_called_once()
service_mock_http.close.assert_not_called()

def test_method_error_checking(self):
self.http = HttpMock(datafile("plus.json"), {"status": "200"})
plus = build("plus", "v1", http=self.http, static_discovery=False)
Expand Down
Loading