chore(deps): update dependency bazelbuild/bazelisk to v1.29.0#16123
chore(deps): update dependency bazelbuild/bazelisk to v1.29.0#16123renovate-bot wants to merge 1 commit into
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Code Review
This pull request updates the Bazelisk version from v1.28.1 to v1.29.0 across five Dockerfiles. The reviewer suggests using an ARG instruction to define the Bazelisk version to improve maintainability and reduce code duplication, as the version string is currently repeated across multiple files.
| mdformat-footnote==0.1.1 | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.
ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH} | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.
ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH} | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.
ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH} | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.
ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH} | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.
ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16123 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 2353 2353
Lines 219451 219451
=======================================
+ Hits 203454 203470 +16
+ Misses 15997 15981 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains the following updates:
v1.28.1→v1.29.0Release Notes
bazelbuild/bazelisk (bazelbuild/bazelisk)
v1.29.0Compare Source
Bazelisk v1.29.0 comes with new features and several improvements:
New Features (Go Binary)
bazeliskVersioncommand so that users can see the Bazelisk version without having to download/run Bazel (#763).New Features (Go Library)
io.Writer(#751).Bug Fixes & Improvements (Go)
execinstead of in a subprocess (#566).We’d like to thank our amazing contributors @aaron-skydio, @isakstenstrom, @PiotrSikora, @sitaktif and @valco1994!
Configuration
📅 Schedule: (UTC)
* * * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.