test(firestore): update integration tests to use enterprise database#8371
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
wu-hui
force-pushed
the
fix-firestore-node-tests
branch
from
f7d0e68 to
84bd2b3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
wu-hui
force-pushed
the
fix-firestore-node-tests
branch
from
84bd2b3 to
566fcc3
Compare
wu-hui
force-pushed
the
fix-firestore-node-tests
branch
4 times, most recently
from
7fbec62 to
bc7acbb
Compare
wu-hui
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
approved these changes
May 28, 2026
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
lgtm, with caveat about isRest() only checking if the env variable is set, but an individual firestore instance could override this.
wu-hui
force-pushed
the
fix-firestore-node-tests
branch
from
bc7acbb to
4fe53b5
Compare
wu-hui
force-pushed
the
fix-firestore-node-tests
branch
from
4fe53b5 to
b922962
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR configures the enterprise integration tests for the Node.js
Firestore SDK to use the
enterprisedatabase instead oftest-db, andruns them with the
RUN_ENTERPRISE_TESTS=yesenvironment variable.