Add missing usedBy field to Certificate type in certificate_manager_v1#17135
Add missing usedBy field to Certificate type in certificate_manager_v1#17135mervin008 wants to merge 1 commit into
usedBy field to Certificate type in certificate_manager_v1#17135Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
usedBy field to Certificate type in certificate_manager_v1
There was a problem hiding this comment.
Code Review
This pull request updates the Certificate message in the Certificate Manager library by adding a used_by field, which tracks resources utilizing the certificate. The feedback suggests reordering the newly added field to maintain numerical consistency with existing fields and removing excessive blank lines between class definitions to adhere to PEP 8 standards.
The REST API Certificate resource exposes a
usedBy[]field (field number 10) of typeUsedBy, but the Python client'sCertificatetype does not include it.Changes
Certificate.UsedByinner message class with anamestring field (field number 1)Certificate.used_byrepeated field (field number 10)Certificateclass docstring to document the new fieldip_configsfield formatting inCertificateMap.GclbTarget(minor syntax fix)Checklist
Fixes #17134 🦕