[testing] for-testing-purposes-automl#17143
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-cloud-automl package to require Python 3.10 or higher, removing support for Python 3.9 and simplifying legacy compatibility code. Key changes include bumping dependency versions, fixing asynchronous method calls in clients and samples, and refining unit test assertions for REST parameters. Review feedback recommends adding Python 3.13 to the test matrix and package classifiers, and restoring the flag to treat documentation warnings as errors.
| "3.9", | ||
| "3.10", | ||
| "3.11", | ||
| "3.12", |
There was a problem hiding this comment.
Since the project now supports Python >= 3.10 and includes conditional dependencies for Python 3.13, it is recommended to include "3.13" in the ALL_PYTHON list to ensure the package is explicitly tested against the latest stable Python version.
| "3.12", | |
| "3.12", | |
| "3.13", |
References
- When updating the minimum supported Python version, ensure that the project's metadata and testing configurations are updated to reflect the supported versions consistently.
| @@ -391,7 +390,6 @@ def docs(session): | |||
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | |||
| session.run( | |||
| "sphinx-build", | |||
There was a problem hiding this comment.
The -W flag was removed from the sphinx-build command. This flag ensures that documentation warnings are treated as errors, which is a best practice for maintaining high-quality documentation and catching issues like broken links or malformed docstrings in CI. It is recommended to restore this flag.
| "sphinx-build", | |
| "sphinx-build", | |
| "-W", # warnings as errors |
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", |
There was a problem hiding this comment.
The project now requires Python >= 3.10 and includes dependencies specifically for Python 3.13 and 3.14. To accurately reflect this support and ensure the package is marked as compatible with the latest stable Python version, please add the "Programming Language :: Python :: 3.13" classifier here.
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", |
References
- When updating the minimum supported Python version, ensure that the project's metadata in 'setup.py' is updated to reflect the supported versions in Trove classifiers.
1 participant
No description provided.