test(spanner): run the inline-begin-fallback test also on real Spanner#5789
Conversation
Enable the integration test inline-begin-fallback to also run on real Spanner, instead of only the emulator. Fixes googleapis#5682
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the PassThroughProxy and test files to support running tests against both the Spanner emulator and real Spanner, enabling TLS configuration and dynamic project/instance resolution. Feedback on the changes highlights a compilation error due to a non-existent with_enabled_roots() method on ClientTlsConfig, and suggests safely skipping the inline_begin_fallback test if the real Spanner configuration is missing to prevent test failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5789 +/- ##
==========================================
- Coverage 97.87% 97.87% -0.01%
==========================================
Files 226 226
Lines 56496 56496
==========================================
- Hits 55298 55297 -1
- Misses 1198 1199 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
LGTM, just a nit on mut vars
3 participants
Enable the integration test inline-begin-fallback to also run on real Spanner, instead of only the emulator.
Fixes #5682