Add declaration tests for WGSL immediate variables#4659
Closed
shaoboyan091 wants to merge 2 commits into
Closed
Conversation
This patch adds the shared CTS plumbing needed by the follow-up WGSL `immediate` address space validation tests. It adds `immediate_address_space` to the known WGSL language feature list, models `immediate` in the address space metadata, and treats it as a module-scope, unbound, read-only address space with host-shareable store types. The validation helpers emit the required WGSL `requires` directive and skip immediate tests when immediate data is not exposed by the browser. The skip checks `setImmediates`/`maxImmediateSize` because current Chrome Canary exposes the API before advertising the WGSL feature. This also removes two now-unnecessary address-space type assertions that became redundant once the shared metadata was typed by `AddressSpace`.
This patch adds a focused declaration suite for `var<immediate>`. The new tests cover accepted scalar, vector, matrix, and struct store types, rejected store types, module-scope-only declarations, rejection of binding attributes, rejection of explicit access modes, and the one-immediate-variable-per-entry-point rule. It also threads `immediate` through the existing declaration tests so the generic address space coverage checks the same declaration access rules as storage, uniform, private, workgroup, and function variables. The context-dependent resolution table now recognizes `immediate_address_space` as a language feature name.
|
Results for build job (at 91f8171): -webgpu:shader,validation,decl,context_dependent_resolution:language_names:* - 4 cases, 12 subcases (~3/case)
+webgpu:shader,validation,decl,context_dependent_resolution:language_names:* - 5 cases, 15 subcases (~3/case)
+webgpu:shader,validation,decl,immediate:store_type,valid:* - 8 cases, 8 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:store_type,invalid:* - 13 cases, 13 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:scope:* - 2 cases, 2 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:binding_attributes:* - 4 cases, 4 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:access_mode:* - 4 cases, 4 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:entry_point_interface:* - 5 cases, 5 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:pointers:* - 8 cases, 8 subcases (~1/case)
-webgpu:shader,validation,decl,var:module_scope_types:* - 406 cases, 406 subcases (~1/case)
+webgpu:shader,validation,decl,var:module_scope_types:* - 464 cases, 464 subcases (~1/case)
-webgpu:shader,validation,decl,var:binding_point_on_non_resources:* - 8 cases, 8 subcases (~1/case)
+webgpu:shader,validation,decl,var:binding_point_on_non_resources:* - 12 cases, 12 subcases (~1/case)
-webgpu:shader,validation,decl,var:address_space_access_mode:* - 40 cases, 40 subcases (~1/case)
-webgpu:shader,validation,decl,var:explicit_access_mode:* - 18 cases, 18 subcases (~1/case)
-webgpu:shader,validation,decl,var:implicit_access_mode:* - 6 cases, 6 subcases (~1/case)
-webgpu:shader,validation,decl,var:read_access:* - 13 cases, 13 subcases (~1/case)
-webgpu:shader,validation,decl,var:write_access:* - 13 cases, 13 subcases (~1/case)
[snip - full report in action logs]
-TOTAL: 281361 cases, 2323132 subcases
+TOTAL: 281500 cases, 2323273 subcases |
Contributor
Author
|
Closing this combined PR. We are going back to the separated PR flow: #4658 will carry only the shared support, and the declaration CTS cases will be sent in a follow-up PR after that lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the first WGSL
immediateaddress space validationcoverage.
It includes the shared CTS plumbing required by the tests:
immediate_address_spaceto the known WGSL language featuresimmediatein the shared address space metadataIt then adds declaration validation coverage for
var<immediate>:ptr<immediate>declaration behaviorFollow-up PRs will add type, expression, function, and uniformity
coverage one suite at a time after this lands.
Testing:
npm.cmd run typechecknpm.cmd run lint