Skip to content

Access subgroupMinSize/subgroupMaxSize directly on GPUAdapterInfo #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 2 commits into from
Jun 13, 2026
Merged

Access subgroupMinSize/subgroupMaxSize directly on GPUAdapterInfo #4663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c1e847
Access subgroupMinSize/subgroupMaxSize directly on GPUAdapterInfo
gyagp Jun 12, 2026
b2cad92
Merge branch 'main' into subgroup-size-direct-access
kainino0x Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupAdd.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,10 +482,7 @@ g.test('fragment')
)
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
}
const { subgroupMinSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
t.skipIf(innerTexels < subgroupMinSize, 'Too few texels to be reliable');

Expand Down
5 changes: 1 addition & 4 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupBitwise.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,10 +538,7 @@ g.test('fragment,all_active')
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
const numInputs = t.params.size[0] * t.params.size[1];

interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
}
const { subgroupMinSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
t.skipIf(innerTexels < subgroupMinSize, 'Too few texels to be reliable');

Expand Down
12 changes: 3 additions & 9 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupBroadcast.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,11 +463,8 @@ g.test('compute,split')
const testcase = kPredicateCases[t.params.predicate];
const wgThreads = t.params.wgSize[0] * t.params.wgSize[1] * t.params.wgSize[2];

interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;
for (let size = subgroupMinSize; size <= subgroupMaxSize; size *= 2) {
t.skipIf(!testcase.filter(t.params.id, size), 'Skipping potential undefined behavior');
}
Expand Down Expand Up @@ -696,10 +693,7 @@ g.test('fragment')
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMaxSize: number;
}
const { subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;
t.skipIf(innerTexels < subgroupMaxSize, 'Too few texels to be reliable');

const broadcast =
Expand Down
10 changes: 2 additions & 8 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupElect.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,7 @@ g.test('compute,each_invocation')
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
const wgThreads = t.params.wgSize[0] * t.params.wgSize[1] * t.params.wgSize[2];

interface SubgroupProperties extends GPUAdapterInfo {
subgroupMaxSize: number;
}
const { subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;
t.skipIf(subgroupMaxSize <= t.params.id, 'No invocation selected');

const wgsl = `
Expand Down Expand Up @@ -332,10 +329,7 @@ g.test('fragment')
)
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
}
const { subgroupMinSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
t.skipIf(innerTexels < subgroupMinSize, 'Too few texels to be reliable');

Expand Down
5 changes: 1 addition & 4 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupMinMax.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,7 @@ g.test('fragment')
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
const numInputs = t.params.size[0] * t.params.size[1];

interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
}
const { subgroupMinSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
t.skipIf(innerTexels < subgroupMinSize, 'Too few texels to be reliable');

Expand Down
7 changes: 2 additions & 5 deletions src/webgpu/shader/execution/expression/call/builtin/subgroupMul.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,11 +512,8 @@ g.test('fragment')
)
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;
const innerTexels = (t.params.size[0] - 1) * (t.params.size[1] - 1);
t.skipIf(innerTexels < subgroupMinSize, 'Too few texels to be reliable');
t.skipIf(subgroupMaxSize === 4 && t.params.quadIndex !== 0, 'Duplicate test');
Expand Down
14 changes: 4 additions & 10 deletions src/webgpu/shader/execution/shader_io/compute_builtins.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,8 @@ g.test('subgroup_size')
)
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;

const wgx = t.params.sizes[0];
const wgy = t.params.sizes[1];
Expand Down Expand Up @@ -1183,11 +1180,8 @@ g.test('subgroup_size_attribute')

const { numWorkGroups, numSubgroups } = t.params;

interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;

let atLeastOneSucceeded = false;

Expand Down
7 changes: 2 additions & 5 deletions src/webgpu/shader/execution/shader_io/fragment_builtins.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,11 +1693,8 @@ g.test('subgroup_size')
)
.fn(async t => {
t.skipIfDeviceDoesNotHaveFeature('subgroups' as GPUFeatureName);
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = t.device.adapterInfo as SubgroupProperties;
const subgroupMinSize = t.device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = t.device.adapterInfo.subgroupMaxSize!;

const fsShader = `
enable subgroups;
Expand Down
7 changes: 2 additions & 5 deletions src/webgpu/shader/validation/extension/subgroup_size_control.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,8 @@ g.test('subgroup_size_override_must_be_power_of_2_at_pipeline_creation')
* between subgroupMinSize and subgroupMaxSize inclusive.
*/
async function getValidSubgroupSizes(device: GPUDevice): Promise<number[]> {
interface SubgroupProperties extends GPUAdapterInfo {
subgroupMinSize: number;
subgroupMaxSize: number;
}
const { subgroupMinSize, subgroupMaxSize } = device.adapterInfo as SubgroupProperties;
const subgroupMinSize = device.adapterInfo.subgroupMinSize!;
const subgroupMaxSize = device.adapterInfo.subgroupMaxSize!;
const maxWorkgroupSizeX = device.limits.maxComputeWorkgroupSizeX;

const sizes: number[] = [];
Expand Down
Loading