Skip to content

Add insertBits edge case regression test#4664

Open
sudonatalie wants to merge 1 commit into
gpuweb:mainfrom
sudonatalie:metal-insertbits
Open

Add insertBits edge case regression test#4664
sudonatalie wants to merge 1 commit into
gpuweb:mainfrom
sudonatalie:metal-insertbits

Conversation

@sudonatalie

Copy link
Copy Markdown
Contributor

This reproduces a GPU hang on Mac for the Dawn implementation (see crbug.com/506180954).


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

This reproduces a GPU hang on Mac for the Dawn implementation (see
crbug.com/506180954).
@github-actions

Copy link
Copy Markdown

Results for build job (at aee4691):

+webgpu:shader,execution,expression,call,builtin,insertBits:array_index:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 281385 cases, 2323156 subcases
+TOTAL: 281386 cases, 2323157 subcases

@sudonatalie

Copy link
Copy Markdown
Contributor Author

Currently fails on my M4 Mac and passes following: https://dawn-review.googlesource.com/c/dawn/+/316515

@sudonatalie sudonatalie requested a review from alan-baker June 12, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants