Repository navigation
Fix the README's installation instructions - #35
Merged
Merged
Conversation
The Installation section still pointed at a 7.0.0-M1 build under com.github.grails-plugins on repo.grails.org. The plugin is published to Maven Central as org.grails.plugins:grails-web-console, so show that coordinate at 8.0.0, declared with implementation like the webjar exclusion example above it, and drop the extra repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Installation section still told users to add
com.github.grails-plugins:grails-web-console:7.0.0-M1fromrepo.grails.org. The plugin is published to Maven Central asorg.grails.plugins:grails-web-console(8.0.0-RC1 and RC2 are there now), so the section now showsdependencies { implementation 'org.grails.plugins:grails-web-console:8.0.0' }declared with
implementationto match the webjar exclusion example earlier in the README, and without the extra repository block.Meant to land before 8.0.0 is released so the published README matches the release. Documentation only.