Repository navigation
fix: reject runner.promise when the worker pool or cron exits with an error - #648
Open
Krrishkumar125 wants to merge 1 commit into
Open
Krrishkumar125 wants to merge 1 commit into
Krrishkumar125 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635.
Since 0.17.0,
buildRunnerturns a worker pool (or cron) rejection into astop(...)call and then.catch(noop)s it, soPromise.all([cp, wp])always resolves.runner.promisetherefore resolves after a fatal pool error, and the CLI exits 0.Change: the exit handlers still call
stop()with the same log reason, but on the error path they re-throw the original error (and only swallow a failure ofstop()itself). The existing rejection branch ofPromise.allthen runs andrunner.promiserejects with the pool's error. The clean-exit path is unchanged.Tests (
__tests__/runner.promise.test.ts):completeJobBatchDelay: 0): fails onmainwith"resolved", passes with this changerunner.stop()still resolvesrunner.promiseFull suite passes locally on PostgreSQL 16 (24 suites, 107 tests), plus
yarn lint(no new warnings) andyarn prepack. Added a patch changeset.@priyansh00soni asked to take this on Oct 3; I didn't see a PR since, but happy to close this if you already have one in progress.