Allow one or more format to be used

[bim9262]

Currently this has only been applied to the time block, but any block that doesn't have formats for specific states/conditions could use this do allow one or more format, while still being able to continue using format and format_alt. (This could work as a fix to #2163)

One drawback about this is that I was unable to figure out how to be able to keep the deny_unknown_fields on the Config

This will allow configs to be specified in any of these ways:

[[block]]
block = "time"
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[[block]]
block = "time"
format = " $icon $timestamp.datetime(f:'%a %Y-%m-%d %R %z') "
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[[block]]
block = "time"
format = " $icon $timestamp.datetime(f:'%a %Y-%m-%d %R %z') "
format_alt = " $icon $timestamp.datetime(f:long, l:en-u-ca-hebrew-hc-h23)"
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[[block]]
block = "time"
format = [" $icon $timestamp.datetime(f:'%a %Y-%m-%d %R %z') ", " $icon $timestamp.datetime(f:long, l:en-u-ca-hebrew-hc-h23)"]
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[[block]]
block = "time"
[[block.format]]
full = " $icon $timestamp.datetime(f:'%a %Y-%m-%d %R %z') "
[[block.format]]
full = " $icon $timestamp.datetime(f:long, l:en-u-ca-hebrew-hc-h23)"
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[[block]]
block = "time"
testing = true
[block.format]
full = " $icon $timestamp.datetime(f:'%a %Y-%m-%d %R %z') "
[[block.click]]
button = "left"
action = "next_format"
[[block.click]]
button = "right"
action = "prev_format"

[bim9262]

One drawback about this is that I was unable to figure out how to be able to keep the deny_unknown_fields on the Config

I fount that we can have deny_unknown_fields on the MaybeMultiConfig instead.

[bim9262]

@MaxVerevkin any thoughts on this approach to allow one or more format (either as how formats are currently configured, or as a list of format configs)?

[bim9262]

@ammgws, any concerns with this approach? I only added support to the time block, but it could be added to other blocks. For blocks that already support format_alt, I'd suggest deprecating the action toggle_format for next_format and prev_format.

[ammgws]

On phone now but just to double check before going further, are the examples in your parent comment still the same?

[bim9262]

@ammgws , yes the example config works as before (well except the last time block, which fails on purpose)

The change I made the other day was to keep the behavior that the first format keeps the default_full, default_short for the first format instead of filling it with "". This would only matter in the case that you wanted to set only the first format's short/full format. This is consistent with the behavior today.

Your question did raise an issue for me, what if a block does specify a default for format_alt? Today the only block that does this is the privacy block, all others' format_alt default to "". I think that adding with_default_formats to MaybeMultiConfig would probably be the most ergonomic option.

[bim9262]

I've added support in two other blocks as examples: privacy and weather