Skip to content

harden: secure delete.go (CWE-778) - #330

Open
anupamme wants to merge 1 commit into
groundcover-com:mainfrom
anupamme:fix-repo-cli-cwe-778-delete-audit-logging
Open

anupamme wants to merge 1 commit into
groundcover-com:mainfrom
anupamme:fix-repo-cli-cwe-778-delete-audit-logging

Conversation

@anupamme

@anupamme anupamme commented Oct 1, 2026

Copy link
Copy Markdown

Destructive Kubernetes operations including service deletion, endpoint collection deletion, and namespace deletion execute without structured audit logging. No record is created of who performed the action, when it occurred, or what resources were affected. This is defence-in-depth at cmd/delete.go:282 rather than a vulnerability I can show is exploitable here — it makes the failure mode explicit and bounded. Close it freely if the pattern is intentional.

Reference: CWE-778

What changed

  • cmd/delete.go

Verification

No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.


Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
@baz-reviewer

baz-reviewer Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Add structured audit messages to destructive Kubernetes cleanup operations, including service deletion, endpoint collection removal, and namespace deletion. Update deleteReleaseLeftovers and deleteNamespace to record the targeted resources before executing deletes.

Latest Contributors(0)
UserCommitDate

Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant