[gildub]

Summary by Sourcery

Fix crypto policy handling for primitive fields and enforce minimum hash digest strength.

Bug Fixes:

• Correct crypto policy evaluation to read primitive and parameter metadata from the top-level properties.
• Classify hash algorithms with digests of 128 bits or less as non-compliant.

Tests:

• Update policy tests for the revised property structure and short hash digest compliance behavior.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR fixes crypto policy and reporting logic for the flattened metadata schema by reading primitive and parameterSetIdentifier directly from the properties object, and updates the associated tests and fixtures.

File-Level Changes

Change	Details	Files
Read cryptographic metadata fields directly from the properties object instead of a nested algorithmProperties object.	Update primitive extraction used for package crypto counts. Update parameter-set identifier parsing used by policy evaluation. Revise policy fixtures and assertions to cover the flattened metadata schema.	modules/fundamental/src/crypto/service/mod.rs modules/fundamental/src/crypto/service/policy.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="modules/fundamental/src/crypto/service/policy.rs" line_range="110" />
<code_context>
     fn props_with_primitive(primitive: &str) -> serde_json::Value {
         json!({
-            "algorithmProperties": {
-                "primitive": primitive
-            }
+            "primitive": primitive
</code_context>
<issue_to_address>
**Primitive-field regression passes unnoticed**

When `evaluate_algorithm` does not use the primitive field, `sha1_is_noncompliant` and `keycloak_cbom_algorithms` still pass if `evaluate_algorithm` ignores `primitive`: SHA1 is rejected by its name, while ECDH and EC-secp521r1 return the default Warning. The changed direct-field fixtures therefore do not verify primitive handling.

Add a test whose observable result changes when the direct primitive field is ignored or read from the wrong location.

Also at `modules/fundamental/src/crypto/service/policy.rs:300-302`, `modules/fundamental/src/crypto/service/policy.rs:310`, `modules/fundamental/src/crypto/service/policy.rs:319`.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and if the incoming crypto properties still use the nested algorithmProperties shape, the service will stop reading the primitive and parameter-set identifier and can report an incorrect algorithm policy verdict. This changes crypto-policy evaluation; reverting restores the previous lookups, but any incorrect verdicts already acted on would not be undone.

Blocking findings: modules/fundamental/src/crypto/service/policy.rs:110

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[sourcery-ai]

Sourcery assessment

Approved.

[trustify-ci-bot]

Successfully created backport PR for release/0.7.z:

• fix(crypto): handle primitive field [Backport release/0.7.z] #2823