Skip to content

build: update from node 22 to node 24 [Backport release/0.7.z] - #2824

Merged
ctron merged 1 commit into
guacsec:release/0.7.zfrom
helio-frota:backport-2822-to-release/0.7.z
Oct 28, 2026
Merged

ctron merged 1 commit into
guacsec:release/0.7.zfrom
helio-frota:backport-2822-to-release/0.7.z

Conversation

@helio-frota

@helio-frota helio-frota commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #2822

Summary by Sourcery

Upgrade project workflows to Node.js 24 and document the requirements for building the embedded UIs from source.

New Features:

  • Document the prerequisites and feature options for building and embedding the console and API-only UIs.

Enhancements:

  • Update documentation and workflow environments to use Node.js 24.

CI:

  • Add Node.js 24 setup to the binary build workflow and upgrade documentation-related CI jobs from Node.js 22 to Node.js 24.

Documentation:

  • Add source-build prerequisites and UI selection guidance to the README.

(cherry picked from commit 56b3611)
@sourcery-ai

sourcery-ai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This backport updates GitHub Actions and documentation workflows to Node.js 24, adds Node setup to the binary vendor-archive job, and clarifies the toolchain and feature requirements for source builds that embed the UIs.

Flow diagram for source builds embedding the UIs

flowchart TD
    Prerequisites[Install Node.js 24, Trunk 0.22.1, and wasm32-unknown-unknown] --> Features[Select trustify-ui and ui-console features]
    Features --> CargoBuild[cargo run --bin trustd]
    CargoBuild --> Embedded[Build and embed both UIs]
Loading

File-Level Changes

Change Details Files
Standardize CI, documentation, and binary-vendor workflows on Node.js 24.
  • Add Node.js 24 setup before vendor archive creation.
  • Upgrade documentation checks and builds from Node.js 22 to 24.
.github/workflows/build-binary.yaml
.github/workflows/ci.yaml
.github/workflows/docs.yaml
Document the prerequisites and feature controls for source builds that embed the UIs.
  • Require Node.js 24, Trunk 0.22.1, and the wasm32 Rust target for console builds.
  • Document selecting the console UI, alternate UI, or API-only build with independent Cargo features.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota
helio-frota requested a review from a team October 28, 2026 17:58
@helio-frota helio-frota changed the title build: update from node 22 to node 24 build: update from node 22 to node 24 [Backport release/0.7.z] Oct 28, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ctron
ctron enabled auto-merge October 28, 2026 17:59
@ctron
ctron added this pull request to the merge queue Oct 28, 2026
Merged via the queue into guacsec:release/0.7.z with commit c00f6b5 Oct 28, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Trustify Oct 28, 2026
@helio-frota
helio-frota deleted the backport-2822-to-release/0.7.z branch October 28, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants